improve: UX Enhancements in workspace summary #473
Conversation
Signed-off-by: DominikKawka <[email protected]>
google-oss-prow
bot
added
area/frontend
dominikkawka
changed the title
Signed-off-by: DominikKawka <[email protected]>
|
Hi @jenny-s51 , could you take a look at these changes please? /ok-to-test |
There was a problem hiding this comment.
Thank you for making these changes and great work here @dominikkawka ! Just one comment below - I put up a PR to support PF utility classes. Once it's merged you can consume the changes and apply the code suggestions so we follow best practices for Patternfly component styling.
#476 cc @paulovmr , if you could PTAL when you have a moment it would be much appreciated so we can unblock this. Thanks a lot here 🚀
| @@ -65,7 +65,9 @@ const WorkspaceKindSummaryExpandableCard: React.FC<WorkspaceKindSummaryExpandabl | |||
| <Flex wrap="wrap"> | |||
| <SectionFlex title="Total GPUs in use"> | |||
| <FlexItem> | |||
| <Content> | |||
| <Content | |||
| style={{ fontSize: LargeFontSize.value, fontWeight: BoldFontWeight.value }} | |||
There was a problem hiding this comment.
When #476 is merged, we can apply the corresponding utility classes here:
| style={{ fontSize: LargeFontSize.value, fontWeight: BoldFontWeight.value }} | |
| className="pf-v6-u-font-size-4xl pf-v6-u-font-weight-bold" |
There was a problem hiding this comment.
Thanks @jenny-s51 , #476 is now merged.
Signed-off-by: DominikKawka <[email protected]>
Signed-off-by: DominikKawka <[email protected]>
There was a problem hiding this comment.
Enhancements LGTM @dominikkawka!
Can we get your signoff here as well @tobiastal? Just a quick question for you on the Idle GPU Workspaces too. Currently it looks like this:
For consistency should we update this to be left aligned?
I.e.:
|
Hey @jenny-s51 
|
Signed-off-by: Jenny <[email protected]>
|
Thank you for your review @tobiastal - yes, great catch! @dominikkawka I've PR-ed your branch with the changes: dominikkawka#1 Can you rebase your branch with the latest and then pull in the changes? Then it should be all set to merge. 🚀 |
Signed-off-by: Dominik Kawka <[email protected]>
fix(ws): apply left alignment and fix padding to match other items
Signed-off-by: DominikKawka <[email protected]>
|
Hi @ederign, when you have a moment, can you please kindly take a look? If you can help us merge this one would be much appreciated. Thank you 🚀 |
Signed-off-by: DominikKawka <[email protected]>
Signed-off-by: Dominik Kawka <[email protected]>
Signed-off-by: DominikKawka <[email protected]>
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
* Workspace Kinds Summary:UX Enchancements Signed-off-by: DominikKawka <[email protected]> * frontend build and test fix Signed-off-by: DominikKawka <[email protected]> * replaced inline styling with PF utility classes Signed-off-by: DominikKawka <[email protected]> * prettier check Signed-off-by: DominikKawka <[email protected]> * fix(ws): apply left alignment and fix padding to match other items Signed-off-by: Jenny <[email protected]> * prettier check Signed-off-by: DominikKawka <[email protected]> * resolved merge conflict Signed-off-by: DominikKawka <[email protected]> * fixed merge conflicts Signed-off-by: DominikKawka <[email protected]> --------- Signed-off-by: DominikKawka <[email protected]> Signed-off-by: Jenny <[email protected]> Signed-off-by: Dominik Kawka <[email protected]> Co-authored-by: Jenny <[email protected]>
closes: #461, #462, #463,
related: #458